Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb doesn't work on routes using matcher #170

Closed
DanGM96 opened this issue Jun 22, 2023 · 5 comments
Closed

Breadcrumb doesn't work on routes using matcher #170

DanGM96 opened this issue Jun 22, 2023 · 5 comments
Labels
bug Something isn't working no-issue-activity wontfix This will not be worked on

Comments

@DanGM96
Copy link

DanGM96 commented Jun 22, 2023

馃悶 Bug report

Description

I have a project with custom routes starting with "@", the only way to do that is using matcher, but path can't be used with it.
And I noticed the breadcrumbs will only identify routes with path.
I tried giving it a look on your code but I couldn't find the exact position of this problem.

馃敩 Minimal Reproduction

Using the exact same matcher as provided by this guide: Angular docs

馃捇Your Environment

Angular Version: ^16.0.2

@DanGM96 DanGM96 added the bug Something isn't working label Jun 22, 2023
@github-actions
Copy link

Hello 馃憢 @DanGM96
Thank you for raising an issue. We will investigate into the issue and get back to you as soon as possible. Please make sure you have given us as much context as possible.
Feel free to raise a PR if you can fix the issue. Check the local development guide

@mohamed351
Copy link

mohamed351 commented Aug 1, 2023

I have the same but i don't have "@" problem and i fix it with just inspection of code i didn't use the componet i used service i use version "xng-breadcrumb": "^9.0.0",
my code it just injecting the service

constructor(public bsService:BreadcrumbService) { }

           <ol class="breadcrumb">
            <li class="breadcrumb-item" *ngFor="let item of this.bsService.breadcrumbs$|async"><a class="text-decoration-none " [routerLink]="[item.routeLink]">{{item.label}}</a></li>
          </ol> 

@DanGM96
Copy link
Author

DanGM96 commented Aug 25, 2023

Sorry if I wasn't clear @mohamed351, I can get the breadcrumb functionalities to work on all cases, except when a route has the matcher property on AppRoutingModule.
In that case, the BreadcrumbService service won't get the information for that specific route.

Copy link

stale bot commented Mar 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 13, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants