Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb link disappears on CanDeactivate guard check #138

Closed
udayvunnam opened this issue Jun 8, 2022 · 5 comments
Closed

Breadcrumb link disappears on CanDeactivate guard check #138

udayvunnam opened this issue Jun 8, 2022 · 5 comments

Comments

@udayvunnam
Copy link
Owner

Here you go.

https://stackblitz.com/edit/angular-xng-breadcrumbs-bkzine?file=src/app/app.routing.module.ts

For some reason, I am not able to get the resolved data in Page2ChildComponent via http service. Hence I am throwing an error from the Resolver.

Steps:

  1. While on Page1, click on Page 2 button -> Page 2 BC text is displayed.
  2. Click on "To Page2 Child" -> Resolver throws error hence "Page 2 child" BC should not be displayed but it is displayed.
  3. Click on "Page 2" button. Nothing happens. It means the rendered component is still "Page 2". Only when "Page 1" button is clicked is when Page 1 component is rendered.

BC should wait until all the resolvers attached to the route are resolved before the BC for the route is shown. If any error occurs, the BC should not be shown

Originally posted by @nakash2050 in #111 (reply in thread)

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Hello 👋 @udayvunnam
Thank you for raising an issue. We will investigate into the issue and get back to you as soon as possible. Please make sure you have given us as much context as possible.
Feel free to raise a PR if you can fix the issue. Check the local development guide

@stale
Copy link

stale bot commented Oct 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 12, 2022
@udayvunnam udayvunnam removed the wontfix This will not be worked on label Oct 12, 2022
@udayvunnam
Copy link
Owner Author

not stale

@stale
Copy link

stale bot commented Feb 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 11, 2023
@stale stale bot closed this as completed Jun 11, 2023
@udayvunnam udayvunnam reopened this Mar 17, 2024
@stale stale bot removed the wontfix This will not be worked on label Mar 17, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant