Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validateRequired enhancements #60

Open
drejc opened this issue Aug 27, 2020 · 1 comment
Open

validateRequired enhancements #60

drejc opened this issue Aug 27, 2020 · 1 comment

Comments

@drejc
Copy link

drejc commented Aug 27, 2020

  1. config.validateRequired() does not check for empty values only nulls
  2. the throw UnsetValueException holds only item name, does not telling which exact item is not set.

For instance if you have a configuration like this:

host:
   url:
   port:

database:
   url:
   port:

UnsetValueException will for instance throw "item url not set", better would be "host.url not set"

@stale
Copy link

stale bot commented Jan 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs, but feel free to re-open a closed issue if needed.

@stale stale bot added the stale label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants