-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSpecify: support annotated type arguments from an enclosing class #836
Labels
jspecify
Related to support for jspecify standard (see jspecify.dev)
Comments
msridhar
added
the
jspecify
Related to support for jspecify standard (see jspecify.dev)
label
Sep 29, 2023
msridhar
added a commit
that referenced
this issue
Oct 18, 2023
…es (#837) This is a step towards fixing #836. We now properly handle the case of a generic enclosing type for an inner class type, both in checking matching of type argument nullability and in pretty-printing for error messages. We still don't handle `NewClassTree` types correctly which is why #836 is not yet fixed. Also fixes a bug in where generics checks were performed for `return` statements. Previously we would only check generic type arguments if the top-level nullability of the return type was `@NonNull`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See the test
NullAwayJSpecifyGenericsTests#overrideAnonymousNestedClass
which is ignored since it fails.Originally posted by @msridhar in #808 (comment)
The text was updated successfully, but these errors were encountered: