Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models interface should push and pop default allocator context on eval #219

Open
mbartling opened this issue Nov 30, 2020 · 3 comments
Open
Assignees
Labels

Comments

@mbartling
Copy link
Member

To support multiple allocator contexts in the tensor destructor, model interface should push and pop current allocator pointers to a queue in the default current context else risks failed destruction

@mbartling mbartling added the bug label Nov 30, 2020
@mbartling mbartling self-assigned this Nov 30, 2020
@mbartling
Copy link
Member Author

@dboyliao found it

@dboyliao
Copy link
Member

@dboyliao
Copy link
Member

As a side note, the main issue is that we need to switch the ram & meta allocator back to those in the user space after model eval.
Since model eval will temporary switch allocators to the ones inside the model, not the ones in user space.

If we forget to switch allocators back, tensor deconstructor will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants