-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Add shape checking to Placeholder Tensors #166
Comments
@mbartling Your point is valid. This relates to a trade-off between runtime's simplicity and code-gen's complexity. Perhaps, a middle ground would be using C++'s |
@neil-tan I completely disagree. This is 100% a runtime issue only and should not be pushed into codegen. It is a single if case. |
+1000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now there is no shape checking on Placeholder tensors, this means that invalid shapes will still propagate through the model and lead to weird errors.
The text was updated successfully, but these errors were encountered: