Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile on save support #9

Open
angelozerr opened this issue Sep 30, 2017 · 6 comments
Open

Compile on save support #9

angelozerr opened this issue Sep 30, 2017 · 6 comments

Comments

@angelozerr
Copy link

tsserver provides support for compile on save https://github.com/Microsoft/TypeScript/blob/master/src/server/protocol.ts#L18 by providing CompileOnSaveAffectedFileList and CompileOnSaveEmitFile commands.

I'm consuming thoses commands in https://github.com/angelozerr/typescript.java and it works well. It should be fantastic if typescript-lsp could provide a custom LSP command for this feature.

@angelozerr
Copy link
Author

@svenefftinge is there a feature that you will be aware to implement? I'm studying how to migrate https://github.com/angelozerr/typescript.java to lsp4e, but without this feature I cannot manage compile on save with Eclipse Builder (and manage progress monitor because with tsc we cannot do that)

@svenefftinge
Copy link
Contributor

I'm currently too busy with other things, but would happily accept and review a PR :)

@angelozerr
Copy link
Author

Great:) I must just convince @mickaelistria to migrate from javascript-typescript-langserver to typescript-language-server in Eclipse BlueSky eclipse-wildwebdeveloper/wildwebdeveloper#22

A very good news with typescript-language-server is that

@mickaelistria
Copy link

I must just convince @mickaelistria to migrate from javascript-typescript-langserver to typescript-language-server in Eclipse BlueSky

The best way to convince me is to submit a patch and show me a demo of the benefits provided by this new LS compared to the current one. BlueSky would pragmatically take the one that feels the best for users.

@angelozerr
Copy link
Author

The best way to convince me is to submit a patch and show me a demo of the benefits provided by this new LS compared to the current one

Yes sure:) It is in my scope. There are some regression with typescript-language-server like #15 so I would like to be sure that regression will fe fixed before doing a demo

@tsujp
Copy link

tsujp commented Sep 18, 2019

Was there any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants