-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile on save support #9
Comments
@svenefftinge is there a feature that you will be aware to implement? I'm studying how to migrate https://github.com/angelozerr/typescript.java to lsp4e, but without this feature I cannot manage compile on save with Eclipse Builder (and manage progress monitor because with tsc we cannot do that) |
I'm currently too busy with other things, but would happily accept and review a PR :) |
Great:) I must just convince @mickaelistria to migrate from javascript-typescript-langserver to typescript-language-server in Eclipse BlueSky eclipse-wildwebdeveloper/wildwebdeveloper#22 A very good news with typescript-language-server is that
|
The best way to convince me is to submit a patch and show me a demo of the benefits provided by this new LS compared to the current one. BlueSky would pragmatically take the one that feels the best for users. |
Yes sure:) It is in my scope. There are some regression with typescript-language-server like #15 so I would like to be sure that regression will fe fixed before doing a demo |
Was there any progress on this? |
tsserver provides support for compile on save https://github.com/Microsoft/TypeScript/blob/master/src/server/protocol.ts#L18 by providing
CompileOnSaveAffectedFileList
andCompileOnSaveEmitFile
commands.I'm consuming thoses commands in https://github.com/angelozerr/typescript.java and it works well. It should be fantastic if typescript-lsp could provide a custom LSP command for this feature.
The text was updated successfully, but these errors were encountered: