Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: equivalent of reportStyleCheckAsWarnings #347

Open
axelson opened this issue Dec 29, 2021 · 1 comment
Open

Feature Request: equivalent of reportStyleCheckAsWarnings #347

axelson opened this issue Dec 29, 2021 · 1 comment
Projects

Comments

@axelson
Copy link
Contributor

axelson commented Dec 29, 2021

In VSCode there is the option "typescript.reportStyleChecksAsWarnings": true. This changes some common errors reported by typescript to be shown in the editor as a warning:
https://github.com/Microsoft/vscode-docs/blob/main/docs/typescript/typescript-compiling.md#why-are-some-errors-reported-as-warnings

Here is where the specific errors to convert to warnings are defined:
https://github.com/microsoft/vscode/blob/c1c103dee729b6f702c1c5272d25b24ea9664d48/extensions/typescript-language-features/src/typeScriptServiceClientHost.ts#L38-L46

It would be nice to have this in typescript-language-server as well because when I develop with errors being reported as I type, and the errors that are converted by reportStyleCheckAsWarnings are errors that I generally don't care about until I finish a segment of code. But those errors tend to drown out the more serious errors. By showing those errors as warnings instead they could be filtered by the editor to display them differently (e.g. with a yellow line instead of red line).

@rchl rchl added this to To do in Roadmap via automation Jan 3, 2022
@rchl
Copy link
Member

rchl commented Sep 30, 2022

I wonder if this is still relevant... The relevant diagnostics are reported as hints here so I'm not sure if this needs specific tsconfig.json to reproduce or typescript has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
To do
Development

No branches or pull requests

2 participants