-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide documentation around what a client should support #181
Comments
Documentation on our end is going to be pretty laborious since every client has their own way of defining these custom commands. If you're trying to implement this for VIM though, here's something you can use for reference: eclipse jdt lsp implements a ton of custom commands and there's an equivalent Neovim project https://github.com/mfussenegger/nvim-jdtls for all of those custom commands It might be worth documenting what custom commands we have, but I think how to define those on various clients is probably not worth it |
I know how to define the custom commands in neovim but the interaction is not super clear. What commands is TLS providing, what commands need to be implemented by the client? What is the meaning of them (for server commands) and what should they do (for client commands), what arguments should be/are provided to them, ... Also what arguments are possible to configure, ... Basically the LSP spec leaves a lot open to the LSP server itself, which is good, but ideally those things would be documented as well so writing the actual LSP client is easy |
The |
Though there is still |
Though there is currently no code in |
This code says something about "to be implemented by the client" https://github.com/theia-ide/typescript-language-server/blob/3a8ea0f04bde047e2f60b9f68ef7816e3a41aa10/server/src/commands.ts#L14 but I cannot find any documentation as to how to implement this.
E.g. what's the flow if you want to support refactorings in non VS-Code environments?
I'm trying to implement this in VIM but I find it hard to figure out how it's supposed to work.
The text was updated successfully, but these errors were encountered: