Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-js outdated #342

Open
oliverjessner opened this issue Feb 22, 2021 · 4 comments · May be fixed by #363
Open

core-js outdated #342

oliverjessner opened this issue Feb 22, 2021 · 4 comments · May be fixed by #363

Comments

@oliverjessner
Copy link

Core-js <3 is no longer supported. Is it possible to update to version 3?
I would make audits much easier for everyone.

Actual behavior

As far as I can see you are using version 2.

Steps to reproduce the behavior

NPM install

@oliverjessner
Copy link
Author

Friendly bump

@erikt9
Copy link

erikt9 commented Oct 1, 2021

This also results in a large bundle size increase as core-js is often getting included twice by importing twitter-text (core-js@3 at the top level and core-js@2 within this package).

A workaround, for the bundle size issue at least:

If you are using webpack 5 and are already including core-js polyfills (e.g., via @babel/preset-env), you can configure webpack to simply not include the older version of core-js. This assumes your node_modules is in the same directory as your webpack config file, and you are including a more modern core-js in your package.json:

{
...
  resolve:
    alias: {
    [path.resolve(__dirname, 'node_modules/twitter-text/node_modules/core-js')]: false
  }
}

@GertSallaerts GertSallaerts linked a pull request Nov 3, 2021 that will close this issue
@johannesnagl
Copy link

Yet another friendly bump! This would be really important for us.

@deadcoder0904
Copy link

deadcoder0904 commented Jun 26, 2022

merge #363 plz :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants