New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parts of js/README.md are wrong #323
Labels
Comments
There is also a broken link in the js readme:
|
Thanks, we moved that content to https://developer.twitter.com/en/docs/basics/counting-characters - will make a note to update that for the next time we sync with GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Until earlier today when I found myself wanting to understand how Twitter calculates the length of a potential tweet and needed to do some tests, I'd never done anything with Node.js. But I'm pretty certain that parts of https://github.com/twitter/twitter-text/blob/master/js/README.md are wrong.
I was confused by
because the following code is
so where does
twttr.txt
come from? But the rest of the example code usestwttr.txt
so I thought I guess it's correct and it's just my lack of understanding of how this stuff works. So I assembled the following, copy/pasted from the example codeAnd it didn't work.
So I changed line 3 to
and that worked.
The "Tweet Parsing" section describes the fields
validDisplayRangeStart
andvalidDisplayRangeEnd
neither of which appear in the example output that follows. The order of fields in the example outputdoesn't match the order they appear in actual output
The text was updated successfully, but these errors were encountered: