Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query methods to CMSSummation #621

Open
johnynek opened this issue Feb 6, 2017 · 3 comments
Open

Add query methods to CMSSummation #621

johnynek opened this issue Feb 6, 2017 · 3 comments

Comments

@johnynek
Copy link
Collaborator

johnynek commented Feb 6, 2017

https://github.com/twitter/algebird/blob/develop/algebird-core/src/main/scala/com/twitter/algebird/CountMinSketch.scala#L150

If we had that, we could reuse CMSSummation as a mutable CMS.

@johnynek
Copy link
Collaborator Author

johnynek commented Feb 6, 2017

cc @non

@jordanrule
Copy link

Am I reading this ticket right in that you just want an accessor/mutator for the private vals in CMSSummation? I'm looking for a good introductory ticket and this could be a good one.

@johnynek
Copy link
Collaborator Author

see:

frequency, innerProduct, totalCount.

The idea is those should also be on the CMSSummation so you don't need to allocate to make queries like that in a mutable context (which is nice to avoid, but not always easy to and retain the highest performance).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants