Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught FileOpenError: android.content.ActivityNotFoundException #6893

Open
ganthern opened this issue Apr 26, 2024 · 0 comments
Open

Uncaught FileOpenError: android.content.ActivityNotFoundException #6893

ganthern opened this issue Apr 26, 2024 · 0 comments
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors

Comments

@ganthern
Copy link
Contributor

ganthern commented Apr 26, 2024

When we receive a android.content.ActivityNotFoundException because of an unknown attachment file type that can't be opened (eg .pgp or .asc), it's correctly mapped to a FileOpenError, but the call escapes the async chain because a604bad removed the await in FileController.ts#69:

}
}
if (downloadedFiles.length > 0) {
if (action === DownloadPostProcessing.Open) {
this.openDownloadedFiles(downloadedFiles)
} else {
await this.writeDownloadedFiles(downloadedFiles)
}

I'm not sure what the intention was here because that change is part of a huge commit, so here is a report.

@ganthern ganthern added bug broken functionality, usability problems, unexpected errors android issues that concern the android client but not all clients labels Apr 26, 2024
@ganthern ganthern changed the title we don't handle FileOpenError anymore Uncaught FileOpenError: android.content.ActivityNotFoundException Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors
Projects
None yet
Development

No branches or pull requests

1 participant