Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-upload image-card style images should have object-fit contain not fill #5855

Open
5 tasks done
wc-matteo opened this issue Apr 10, 2024 · 0 comments · May be fixed by #5859
Open
5 tasks done

n-upload image-card style images should have object-fit contain not fill #5855

wc-matteo opened this issue Apr 10, 2024 · 0 comments · May be fixed by #5859
Labels
untriaged need to sort

Comments

@wc-matteo
Copy link

wc-matteo commented Apr 10, 2024 •
edited

Describe the bug

fill

image

contain

image

Steps to reproduce

  1. go the the minimal reproduction
  2. try to upload this picture:
    port
  3. see how it gets distorted in the thumbnail

Link to minimal reproduction

https://codesandbox.io/s/vsckml

System Info

System:
  OS: Windows 10 10.0.19045
  CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
  Memory: 5.61 GB / 15.80 GB
Binaries:
  Node: 20.11.1 - ~\AppData\Local\Volta\tools\image\node\20.11.1\node.EXE
  Yarn: 1.22.19 - ~\AppData\Local\Volta\tools\image\yarn\1.22.19\bin\yarn.CMD
  npm: 10.5.0 - ~\AppData\Local\Volta\tools\image\npm\10.5.0\bin\npm.CMD
  pnpm: 8.15.6 - C:\Program Files\Volta\pnpm.EXE
  bun: 1.1.0 - ~\.bun\bin\bun.EXE
  Watchman: 4.9.4 - C:\Users\Matteo\bin\watchman.EXE
Browsers:
  Edge: Chromium (123.0.2420.81)
  Internet Explorer: 11.0.19041.3636

Used Package Manager

pnpm

Validations
@wc-matteo wc-matteo added the untriaged need to sort label Apr 10, 2024
@jahnli jahnli linked a pull request Apr 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
untriaged need to sort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(n-upload): add image-props props jahnli/naive-ui
1 participant
@wc-matteo