Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] allow individual renderpaths to enable wireframe, and other currently global renderer settings. #756

Open
AnthonyPython opened this issue Sep 26, 2023 · 2 comments
Labels
bug Need to fix

Comments

@AnthonyPython
Copy link

scr0
As you can see when trying to enable wireframe on multiple setting to true and false before and after render/update only affects the last one.
It would nice to allow other renderer global ones also be-able to be enabled/ disabled for example global Illumination in a single renderpath. there is probably a few others I had not looked at but it would be nice to allow.

@turanszkij turanszkij added the bug Need to fix label Sep 27, 2023
@turanszkij
Copy link
Owner

What exactly happens if you enable wire rendering for the other renderpath views? As far as I see, checking if wire rendering is active only happens in drawing functions like DrawScene() so it should work as an immediate turn on/off setting.

Can you debug into what happens when an other renderpath view is rendering that is not the last if it enters into here: https://github.com/turanszkij/WickedEngine/blob/master/WickedEngine/wiRenderer.cpp#L2725

@AnthonyPython
Copy link
Author

will do so, it is rather odd behavior as you say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Need to fix
Projects
None yet
Development

No branches or pull requests

2 participants