-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to TanStack Query v5 #415
Comments
This would be awesome! 🚀 |
One caveat to this: All of our packages are currently in sync. We'd have to break this convention to not let others be forced to upgrade (should they want the latest @ts-rest/core package, for instance). If the community is OK with upgrading to react-query v5, I'm also cool with it, so as long as we properly communicate @ts-rest/vX will force you to upgrade react query. |
It is peerDependency to "@tanstack/react-query": "^4.0.0", would be good if it could handle both like: |
+1 on this one! |
+1 |
I suggest to do this incrementally. v4 already supports object syntax for query options (1st item in the migration guide):
This could be done under the hood as a non-breaking change, thus supporting v4 and v5 as a peer dependency. I would imagine that this fixes 90% of use-cases. I implemented vue-query in this manner and have been using it with v5 without issue. |
@Gabrola, we're using Wanted to flag that |
Read the announcement post here: https://tanstack.com/blog/announcing-tanstack-query-v5
Read the migration guide here: https://tanstack.com/query/v5/docs/react/guides/migrating-to-v5
The text was updated successfully, but these errors were encountered: