Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the solid-query adapter fully #110

Open
oliverbutler opened this issue Dec 18, 2022 · 4 comments
Open

Release the solid-query adapter fully #110

oliverbutler opened this issue Dec 18, 2022 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@oliverbutler
Copy link
Collaborator

@ts-rest/solid-query is 95% working, the only broken part is that the args attribute should be a callback so that solid js can react to changes to params/query params etc.

Screenshot 2022-12-18 at 13 52 50

  • Fix () -> args
  • Fix data return type to make sure it's { status, body } just like the rest of ts-rest
@oliverbutler oliverbutler added the enhancement New feature or request label Dec 18, 2022
@oliverbutler oliverbutler self-assigned this Dec 18, 2022
@oliverbutler
Copy link
Collaborator Author

Looks like it's going to work off the bat with solid-start, which will be awesome. I'll try crack on with the lib fix. Still having issues developing it inside the monorepo though.

@oliverbutler
Copy link
Collaborator Author

Aha! following the solid docs by changing the query to be "get query()" works

Screenshot 2022-12-18 at 16 31 20

@oliverbutler
Copy link
Collaborator Author

Ah! the other problem with data typing was an error I had in the contract. @ts-rest/solid-query appears to be fully working.

Documentation work still remaining!

@oliverbutler oliverbutler added the documentation Improvements or additions to documentation label Dec 18, 2022
@baijanathTharu
Copy link

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants