Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find is broken on GitHub file views #4985

Open
GordianDziwis opened this issue May 23, 2024 · 3 comments
Open

find is broken on GitHub file views #4985

GordianDziwis opened this issue May 23, 2024 · 3 comments

Comments

@GordianDziwis
Copy link

I have bind / to find with:

bind / fillcmdline find

But this does not work on file view pages on GitHub.

  1. Navigate to a file
  2. Place the cursor somewhere outside the file
  3. Press the keys /foo, press Return
  4. Gives the error: # controller in excmd: IndexSizeError: Index or size is negative or greater than the allowed amount

2b. Place the cursor somewhere INSIDE the file
3b. Press /
4b. No search, but cursor goes to the end of the file

How to override this, so that / always calls find and works?

@bovine3dom
Copy link
Member

bovine3dom commented May 23, 2024

Not a Tridactyl fix, but try https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-user-account-settings/managing-accessibility-settings#managing-keyboard-shortcuts

Edit: sorry, that won't fix the :find command, but you could try :unbindurl github\.com / and then use the built-in Firefox find instead

@GordianDziwis
Copy link
Author

Thanks, but not really an option, / and n are muscle memory and I use it everywhere.
I found a workaround, by browsing the repos locally with git-dev.

I integrated it with tridactyl:

bind <Space>gv browse_repo
command browse_repo composite get_current_url | js -p tri.excmds.exclaim("alacritty -e zsh -c \"vi -c \'GitDevOpen " + JS_ARG + "\'\"")

@GordianDziwis
Copy link
Author

I did not find an GitHub issue to link to, just a discussion: https://github.com/orgs/community/discussions/5760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants