#934 Added command to clear all data in the table: #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added "Clear all rows" command to MoreMenu. After clicking and confirming the action, the system will clear all rows in the table. + In order to be able to use text variant, added passing of text variant through MenuItem to Text
|
@trey-wallis Hi, could you check out the PR, please? |
1 similar comment
|
@trey-wallis Hi, could you check out the PR, please? |
|
Hi @42ama. I am sorry that I didn't get back to you. I am no longer developing DataLoom. I will be working on other projects from now on. I will post more about this in the README. I will be closing this request for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trey-wallis hi, could you check the PR please?
The only place I doubt is that I had to duplicate the possible values that can be passed to
textVariant. Now there are two places in the plugin where this enumeration is present ("semibold" | "faint" | "muted" | "on-accent" | "error" | "normal"). This is in theMenuItem.textVariantdefinition and inText.variant. It would be nice to get this definition into a single place, but I had no idea how. In general, you could put these values in enum, but then backward compatibility and the ability to set thevairantproperty with string would break.