Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent scoring between different URLs #27

Open
tbigueres opened this issue Jun 25, 2019 · 2 comments
Open

Consistent scoring between different URLs #27

tbigueres opened this issue Jun 25, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@tbigueres
Copy link

Hello,

First of all thanks for the work you've done ! it looks very promising !
I had some question about how you guys calculate the new score ? I imagine there's some sort of comparaison between the score with and without the extension ?

I wonder how the url you pass in as test url can impact the new score !
Indeed I tried it with a plugin we've created that display a bar when you arrive on a partner website.

If I go on a website that is not a partner it does nothing.

What I expected was to have a difference between the partner and non partner site as there is more javascript executed on partners' sites.

Here is the scrore I had by running the exthouse command with --runs=3

  • Non partner => 98 (pretty good)

  • Partner 1 => 53

  • Partner 2 => 98

  • Partner 3 => 70

The script executed should be the same between the three partners !

Do you guys have any idea how this can happen ?

Thanks again for the great work !

@alekseykulikov
Copy link
Member

Hi @tbigueres!
Thank you for your kind words and for submiting the issue.

In the first iteration, we focused on https://example.com and scoring around it.
Consistent scoring between different URLs wasn't a priority, but it will, especially with #22 support.

Could you provide the URLs and the extension, so we could try to debug it?

@alekseykulikov alekseykulikov changed the title Big difference in score, when url differs Consistent scoring between different URLs Jun 26, 2019
@alekseykulikov alekseykulikov added the bug Something isn't working label Jun 26, 2019
@tbigueres
Copy link
Author

Ok I completely understand :)

So here is the extension I was trying to test https://chrome.google.com/webstore/detail/macif-avantages/oipjcohppciapfdojclipkpddkncidjo

And here are the urls :

$(npm bin)/exthouse macif.crx --runs=3 --url=https://www.google.com
$(npm bin)/exthouse macif.crx --runs=3 --url=https://www.masalledesport.com/
$(npm bin)/exthouse macif.crx --runs=3 --url=http://www.allshot.eu/index.php
$(npm bin)/exthouse macif.crx --runs=3 --url=https://gironderamagebelcier.com/fr/

Thanks a lot for you work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants