We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchInput
Chinese characters entered via the Chinese Pinyin input method trigger excessive renders, as shown below in the "Keyword Search" example:
Note: This issue only occurred in v1. v0 does not have this problem.
Several related issues have been identified:
inputValue
useCombobox
onChange
To resolve this issue, it's recommended to set the value immediately for controlled input or textarea, regardless of whether it's controlled or not.
const onChange = useCallback((e) => { const nextValue = ensureString(e.target.value ?? ''); - const isControlled = (valueProp !== undefined); - - if (!isControlled) { - setValue(nextValue); - } + setValue(nextValue);
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Description
Chinese characters entered via the Chinese Pinyin input method trigger excessive renders, as shown below in the "Keyword Search" example:
Note: This issue only occurred in v1. v0 does not have this problem.
Several related issues have been identified:
inputValue
inuseCombobox
downshift-js/downshift#1452onChange
override zendeskgarden/react-containers#588Resolution
To resolve this issue, it's recommended to set the value immediately for controlled input or textarea, regardless of whether it's controlled or not.
The text was updated successfully, but these errors were encountered: