-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: BarList takes data with JSX Elements, but shows type error #945
Comments
Hi @jschuur has this issue been resolved with |
Hi @severinlandolt, I can confirm it is
I'm assuming that it doesn't accept tremor/src/components/vis-elements/BarList/BarList.tsx Lines 101 to 113 in bd6566b
|
Hey there! This is a use-case I haven't thought of. Thanks @BenJenkinson for investigating. Since we apply our own className, I am not keen on changing this logic at the moment. However: We recently launched Tremor Raw, a copy & paste library for React components. Here we have a new version of the BarList, where you have full control over this :) |
Hi @severinlandolt & @jschuur, My apologies, but I just realised that I misread @jschuur's question. He wasn't asking about the The tremor/src/components/vis-elements/BarList/BarList.tsx Lines 132 to 134 in bd6566b
It's currently typed as
The only thing that would need to change is the two places where the
|
Just published an overhauled version of the BarList, happy to review a PR for this :) |
🎉 This issue has been resolved in version 3.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Tremor Version
3.13.4
Link to minimal reproduction
n/a
Steps to reproduce
I'm setting the
name
property of the data array passed into aBarList
to a JSX Element and this renders fine, but I get a TypeScript error because the type fordata
doesn't allow for Elements.What is expected?
Should not show TypeScript error if it can render JSX Elements in the data.
What is actually happening?
TypeScript error.
The text was updated successfully, but these errors were encountered: