Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Commit with empty message looks skewed #5250

Closed
N-o-Z opened this issue Feb 15, 2023 · 4 comments · Fixed by #7767
Closed

UI: Commit with empty message looks skewed #5250

N-o-Z opened this issue Feb 15, 2023 · 4 comments · Fixed by #7767
Assignees
@itaigilo
Labels
area/UI Improvements or additions to UI bug Something isn't working good first issue Good for newcomers no stale Using this label will prevent items from being marked as stale team/cloud-native Team cloud native tech-debt

Comments

@N-o-Z
Copy link
Member

N-o-Z commented Feb 15, 2023

Commit message is used as a headline for the commit element and is also an href to the commit information.
When creating a commit with empty message it is a little skewed and looks confusing

image
@N-o-Z N-o-Z added bug Something isn't working area/UI Improvements or additions to UI labels Feb 15, 2023
@eladlachmi
Copy link
Contributor

@N-o-Z I believe an empty <a> doesn't render at all in modern browsers. Two simple options I can think of are either to hold its place with no content or use something like "<empty>" to make it more obvious and less broken looking.
WDYT?

@eladlachmi eladlachmi self-assigned this Feb 15, 2023
@eladlachmi eladlachmi added the team/cloud-native Team cloud native label Feb 15, 2023
@N-o-Z
Copy link
Member Author

N-o-Z commented Feb 16, 2023

The "<empty>" option sounds better in my opinion

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

This issue is now marked as stale after 90 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label.

@github-actions github-actions bot added the stale label Nov 1, 2023
@N-o-Z N-o-Z added tech-debt and removed stale labels Nov 1, 2023
@github-actions GitHub Actions
Copy link

This issue is now marked as stale after 90 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label.

@github-actions github-actions bot added the stale label Jan 31, 2024
@N-o-Z N-o-Z added no stale Using this label will prevent items from being marked as stale good first issue Good for newcomers and removed stale labels Jan 31, 2024
@itaigilo itaigilo self-assigned this May 16, 2024
@itaigilo itaigilo mentioned this issue May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itaigilo itaigilo

Labels
area/UI Improvements or additions to UI bug Something isn't working good first issue Good for newcomers no stale Using this label will prevent items from being marked as stale team/cloud-native Team cloud native tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle empty commit messages treeverse/lakeFS
3 participants
@N-o-Z @itaigilo @eladlachmi