You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
A running test session with e.g.pytest --nbmake *.ipynb cannot be terminated with Ctrl-C, the nbmake . The only way to terminate the test session was to kill the pytest process with SIGKILL.
To Reproduce
Run test session on multiple notebooks with a glob:
pytest --nbmake *.ipynb
Then try to terminate it with Ctrl+C.
The text was updated successfully, but these errors were encountered:
Apologies I never replied to this one, I'm aware the nbclient spins up subprocesses to emulate the notebook environment. It's likely we are not handling the SIGKILL signal correctly which is causing it to hang.
This would be a good quality of life improvement and requires a bit of investigation as to how we solve it.
Describe the bug
A running test session with e.g.
pytest --nbmake *.ipynb
cannot be terminated withCtrl-C
, thenbmake
. The only way to terminate the test session was to kill thepytest
process withSIGKILL
.To Reproduce
Run test session on multiple notebooks with a glob:
pytest --nbmake *.ipynb
Then try to terminate it with
Ctrl+C
.The text was updated successfully, but these errors were encountered: