Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the .gitattributes template use text=auto? #3326

Open
3 tasks
DavisVaughan opened this issue Apr 29, 2024 · 2 comments
Open
3 tasks

Should the .gitattributes template use text=auto? #3326

DavisVaughan opened this issue Apr 29, 2024 · 2 comments
Labels

Comments

@DavisVaughan
Copy link
Contributor

Problem

i.e. see tree-sitter/tree-sitter-python#263 (comment) where we went from text to text=auto

This tweak will also have to be done for the other repos that have CRLF files, here are the others i found easily:

But that made me wonder if this template needs updating too
https://github.com/tree-sitter/tree-sitter/blob/master/cli/src/generate/templates/gitattributes

Steps to reproduce

NA

Expected behavior

Be able to do a clean clone of these repos without getting immediate diffs

Tree-sitter version (tree-sitter --version)

tree-sitter 0.22.5

Operating system/version

macOS 13.6.5

@DavisVaughan
Copy link
Contributor Author

DavisVaughan commented Apr 29, 2024

Similarly, should .editorconfig drop end_of_line = lf (as done in the PR that fixed that python issue)?

@ObserverOfTime
Copy link
Member

I've added the fix to #3284.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants