Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verification of expiry and issuance date #3

Open
F-Node-Karlsruhe opened this issue Sep 13, 2023 · 1 comment
Open

Verification of expiry and issuance date #3

F-Node-Karlsruhe opened this issue Sep 13, 2023 · 1 comment

Comments

@F-Node-Karlsruhe
Copy link

Do iat and exp get checked in the verify process? Afaik. they don't. The proposed verifier uses jose.compactVerify(jws, publicKey); which does not check on the dates. Neither this is done for validFrom and validUntil.

Is the user supposed to do these checks? because i tested expired credentials and they verified.
@OR13
Copy link
Sponsor Member

OR13 commented Feb 3, 2024

The "W3C Verifier" can decide to accept expired credentials that have verified successfully, afaik.

The layering between W3C and OAuth is blurred in the current implementation, but should be addressed in our W3C CR1 rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OR13 @F-Node-Karlsruhe