Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labels on highr bucket default metrics #270

Open
blankenshipz opened this issue Oct 11, 2023 · 0 comments
Open

labels on highr bucket default metrics #270

blankenshipz opened this issue Oct 11, 2023 · 0 comments

Comments

@blankenshipz
Copy link

blankenshipz commented Oct 11, 2023

Is there a specific reason that the method and handler labels are not on the default metrics with the "highr" bucket resolution?

For example

LATENCY_HIGHR = Histogram(
name="http_request_duration_highr_seconds",
documentation=(
"Latency with many buckets but no API specific labels. "
"Made for more accurate percentile calculations. "
),
buckets=latency_highr_buckets,
namespace=metric_namespace,
subsystem=metric_subsystem,
registry=registry,
)
LATENCY_LOWR = Histogram(
name="http_request_duration_seconds",
documentation=(
"Latency with only few buckets by handler. "
"Made to be only used if aggregation by handler is important. "
),
buckets=latency_lowr_buckets,
labelnames=(
"method",
"handler",
),
namespace=metric_namespace,
subsystem=metric_subsystem,
registry=registry,
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant