Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Token optional in Python bindings #100

Open
pgoodman opened this issue Sep 16, 2023 · 0 comments
Open

Make Token optional in Python bindings #100

pgoodman opened this issue Sep 16, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pgoodman
Copy link
Member

Some APIs return std::optional<Token> and others return Token knowing that they will be nullable-ish. In the Python bindings, we should specialize nanobind::type_caster<std::optional<::pasta::Token>> and nanobind::type_caster<::pasta::Token> to present both as Optional[Token].
@pgoodman pgoodman added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pgoodman