Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level from Warning to Info when ExternalName services is enabled #10682

Merged
merged 2 commits into from May 13, 2024

Conversation

marcmognol
Copy link
Contributor

What does this PR do?

This PR reduces the level from Warning to Info whenever ExternalName service is enabled with AllowExternalNameServices option for providers Kubernetes CRD and Ingress.

Motivation

Closes #10676

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Contributor

@jspdown jspdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @marcmognol,

Thank you for your contribution.
LGTM 👍

@mmatur mmatur added the kind/enhancement a new or improved feature. label May 6, 2024
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@traefiker traefiker merged commit 6a06560 into traefik:master May 13, 2024
22 checks passed
@marcmognol marcmognol deleted the warning-external-name branch May 13, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Warning when ExternalName service loading is enabled
7 participants