Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with defaults for inline styles #5

Open
winkelsdorf opened this issue Apr 18, 2019 · 2 comments
Open

Issue with defaults for inline styles #5

winkelsdorf opened this issue Apr 18, 2019 · 2 comments

Comments

@winkelsdorf
Copy link

winkelsdorf commented Apr 18, 2019

With the current configuration every style used (e.g. bold, or Links) is rendered on a newline before and after that style.

It's already visible on https://tradle.github.io/rn-markdown-playground/.

Example Markdown:

Please see the following [link](https://www.google.com).

It is usually rendered like here on GH:

Please see the following link.

While using rn-markdown it renders like this:

Please see the following
link
.

This seems to be a bit off the default markdown style, doesn't it? I am wondering if this is coming from your component or marked..

@mvayngrib
Copy link
Member

@winkelsdorf you're right, i think this was broken recently! I restored to a previous version for now, if you'd like to work on compatibility with the latest react/react-native-web, happy to accept PRs :)

@winkelsdorf
Copy link
Author

@mvayngrib I see, thanks for the confirmation! Sorry, won't be able to enhance it currently, tbh I'm mainly a Swift Dev who just needs to get something done in RN quickly. But I'll pin this, just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants