-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G93 code in drill file rendered as drilled hole #353
Labels
Comments
Thanks for the report. Would accept a PR to ensure G93's are no-ops rather than drill hits |
I believe the offending regex is here:
I don't recall why the regex does not start with |
mcous
added
bug
help wanted
Good issues to tackle if you're looking to contribute
labels
Jan 15, 2023
I've the same issue with tracespace 5.0.0-alpha. How to fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am using the pcb-stackup and gerber-to-svg libraries to render a composite image of a bare board. The layout tool I use, Mentor Xpedition, seems to add a G93 code to its drill output to indicate the relative zero coordinate (
G93X0Y0
). _parse-drill.js ignores the G93 part of the line and recognizes the X0Y0 as a drill coordinate. It then seems to incorrectly drill the last defined tool at 0,0.For example, this drill file below will render an extra T10 0.463in hole at 0,0. I think there should probably be a check for G93 codes at the start of the line so they can be ignored as drill coordinates.
The text was updated successfully, but these errors were encountered: