Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug Report: CI does not correctly unit test watsonx #544

Closed
1 task done
paolorechia opened this issue Feb 28, 2024 · 1 comment
Closed
1 task done

馃悰 Bug Report: CI does not correctly unit test watsonx #544

paolorechia opened this issue Feb 28, 2024 · 1 comment

Comments

@paolorechia
Copy link
Contributor

paolorechia commented Feb 28, 2024

Which component is this bug for?

Watsonx Instrumentation

馃摐 Description

As per the discussion in #543, we're currently unable to run unit tests correctly in CI due to conflicts with Python version.

馃憻 Reproduction steps

  1. Remove try/catch added to conftest.py in PR: https://github.com/traceloop/openllmetry/pull/543/files/c5d93cac7894ca7d1b224242ff93bcf320685cf1#
  2. Trigger CI tests. Python 3.10 tests should not fail because package ibm-watsonx-ai was not installed.

馃憤 Expected behavior

CI should test the instrumentation.

馃憥 Actual Behavior with Screenshots

CI runs test, but it's not executing the instrumentation.

馃 Python Version

No response

馃搩 Provide any additional context for the Bug.

No response

馃憖 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

None

@paolorechia paolorechia changed the title 馃悰 Bug Report: watsonx do not run correctly in CI 馃悰 Bug Report: CI does not correclty unit test watsonx Feb 28, 2024
@paolorechia paolorechia changed the title 馃悰 Bug Report: CI does not correclty unit test watsonx 馃悰 Bug Report: CI does not correctly unit test watsonx Feb 28, 2024
@nirga
Copy link
Member

nirga commented Apr 29, 2024

Fixed with #855

@nirga nirga closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants