Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instrumentation): Updated Langchain instrumentation to use Langchain Callbacks #902

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat(instrumentation): Updated Langchain instrumentation to use Langchain Callbacks #902

wants to merge 7 commits into from

Conversation

midhun1998
Copy link

This is a draft PR to record my progress and collaborate with the team to get suggestions.

Supposed to fix #541

I will check the below checkbox when they are ready:

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@CLAassistant
Copy link

CLAassistant commented Apr 28, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@midhun1998
Copy link
Author

midhun1998 commented Apr 28, 2024 •
edited

Note:

  • I know some changes should not go into the final PR. Please bear with me.
  • I will be squashing all the commits as well

I will clean it up before marking this as ready.

Thanks! 😇

@nirga nirga self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nirga nirga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: re-write Langchain instrumentation to use Langchain Callbacks
3 participants
@midhun1998 @CLAassistant @nirga