-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Feature: re-write LlamaIndex instrumentation to use LlamaIndex CallbackManager
#540
Comments
I can start looking into this! |
@nirga , could you fix the link to documentation in the description and give a hint what pieces of this project's code should be touched by this change? |
Done @larinam! A better solution would be to register ourselves to the callbacks of the LlamaIndex engine and just open and close spans when we get called. This is much more robust and future proof. |
All right @nirga , thanks. But I'll try to ask one more time with the question. |
In our project it's just under the LlamaIndex instrumentation. Do you want to join our slack and discuss there? Might be easier :) |
Which component is this feature for?
LlamaIndex Instrumentation
🔖 Feature description
Right now, we monkey-patch classes and methods in LlamaIndex which requires endless work and constant maintenance. LlamaIndex has a system for callbacks that can potentially be used to create/end spans without being too coupled with with the framework's inner structure.
🎤 Why is this feature needed ?
Support LlamaIndex entirely and be future-proof to internal API changes
✌️ How do you aim to achieve this?
Look into LlamaIndex
callback_manager
and how other frameworks are using it.🔄️ Additional Information
No response
👀 Have you spent some time to check if this feature request has been raised before?
Are you willing to submit PR?
None
The text was updated successfully, but these errors were encountered: