Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug Report: disabled tests for GCP / VertexAI #417

Open
1 task done
nirga opened this issue Feb 13, 2024 · 2 comments
Open
1 task done

馃悰 Bug Report: disabled tests for GCP / VertexAI #417

nirga opened this issue Feb 13, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed testing

Comments

@nirga
Copy link
Member

nirga commented Feb 13, 2024

Which component is this bug for?

VertexAI Instrumentation

馃摐 Description

Following #413, I had to disable the VertexAI tests since vcr.py doesn't support GRPC. We need to figure out how to mock those requests to avoid making actual calls to GRPC.

馃憻 Reproduction steps

N/A

馃憤 Expected behavior

N/A

馃憥 Actual Behavior with Screenshots

N/A

馃 Python Version

No response

馃搩 Provide any additional context for the Bug.

No response

馃憖 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

None

@nirga nirga added good first issue Good for newcomers help wanted Extra attention is needed testing labels Feb 13, 2024
@MarkWinter21
Copy link

Hi, does this bug still need to be looked at? Alternatively, could you suggest another 'good first issue'. Thanks

@nirga
Copy link
Member Author

nirga commented May 13, 2024

Yes @MarkWinter21! We can look into either finding something like vcr.py that supports GRPC (which is what VertexAi is using), or just create a stub that mocks the calls to VertexAI ourselves.
There's something more interesting for you to look at though, if you want - #1026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed testing
Projects
None yet
Development

No branches or pull requests

2 participants