Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug Report: Errors are not logged #412

Open
1 task done
nirga opened this issue Feb 8, 2024 · 4 comments
Open
1 task done

馃悰 Bug Report: Errors are not logged #412

nirga opened this issue Feb 8, 2024 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nirga
Copy link
Member

nirga commented Feb 8, 2024

Which component is this bug for?

All Packages

馃摐 Description

If an HTTP error is returned from a foundation model API, we don't properly log it as a failed span.

馃憻 Reproduction steps

N/A

馃憤 Expected behavior

N/A

馃憥 Actual Behavior with Screenshots

N/A

馃 Python Version

No response

馃搩 Provide any additional context for the Bug.

No response

馃憖 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

None

@nirga nirga added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 8, 2024
@HappyLife2
Copy link

Hi @nirga. Could you specify which components or packages within the project interact directly with foundation model APIs? This information will help narrow down the search to the relevant parts of the codebase.

Also, could you provide insight into how a 'failed span' is defined or identified within the context of the project? This will aid in accurately logging the relevant events as failed spans.

@nirga
Copy link
Member Author

nirga commented Feb 26, 2024

Hey @HappyLife2!
These are opentelemetry-instrumentatin-openai, -anthropic, -cohere, -replicate, -bedrock, -vertexai and -transformers.

This is how a failed span should be logged: https://opentelemetry.io/docs/languages/python/instrumentation/#record-exceptions-in-spans

@epg323
Copy link

epg323 commented May 2, 2024

I can be assigned to this one if no one wants it.

@nirga
Copy link
Member Author

nirga commented May 2, 2024

That would be great @epg323 :)
I assume @HappyLife2 is not actively working on this since it's been 2 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants