Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Add logger for traceloop via OpenTelemetry #386

Open
1 task done
gyliu513 opened this issue Jan 31, 2024 · 3 comments
Open
1 task done

🚀 Feature: Add logger for traceloop via OpenTelemetry #386

gyliu513 opened this issue Jan 31, 2024 · 3 comments

Comments

@gyliu513
Copy link
Contributor

Which component is this feature for?

Traceloop SDK

🔖 Feature description

Traceloop instrumentation only have tracer, how about add meter and logger to expose metrics and logs?

🎤 Why is this feature needed ?

opentelemetry support log, metrics and tracing, we should support all those.

✌️ How do you aim to achieve this?

enable meter and logger.

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

Yes I am willing to submit a PR!

@nirga
Copy link
Member

nirga commented Jan 31, 2024

Cool @gyliu513 would love your assistance here! Note that work on metrics have began with #251

@gyliu513
Copy link
Contributor Author

gyliu513 commented Jan 31, 2024

Thanks @nirga , this is great, will create PR for watsonx soon. Shall I update the title for this issue a bit to focus on logger?

@nirga
Copy link
Member

nirga commented Jan 31, 2024

Yes @gyliu513 I think that would be best.

@gyliu513 gyliu513 changed the title 🚀 Feature: Add meter and logger for traceloop 🚀 Feature: Add logger for traceloop via OpenTemetry Jan 31, 2024
@nirga nirga changed the title 🚀 Feature: Add logger for traceloop via OpenTemetry 🚀 Feature: Add logger for traceloop via OpenTelemetry Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants