Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: extract semantic conventions #117

Open
1 task done
nirga opened this issue Oct 26, 2023 · 8 comments · May be fixed by #1131
Open
1 task done

🚀 Feature: extract semantic conventions #117

nirga opened this issue Oct 26, 2023 · 8 comments · May be fixed by #1131
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nirga
Copy link
Member

nirga commented Oct 26, 2023

Which component is this feature for?

All Packages

🔖 Feature description

As the instrumentations grew, there are some semantic conventions that should be extracted out of the individual packages into the common one, namely:

  • LLM prompts
  • Prompt keys
  • Whether to disable prompt logging for privacy reasons

🎤 Why is this feature needed ?

Order in the repo :)

✌️ How do you aim to achieve this?

.

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

None

@nirga nirga added good first issue Good for newcomers help wanted Extra attention is needed enhancement New feature or request and removed help wanted Extra attention is needed labels Dec 15, 2023
@SANJITH-KUMAR-20
Copy link

@nirga he is this open still?

@nirga
Copy link
Member Author

nirga commented Apr 10, 2024

Yes @SANJITH-KUMAR-20. We need to extract strings that are used for attribute names to the common package.

@SANJITH-KUMAR-20
Copy link

Maybe I can try working on this if you ellaborate a bit... Becasue I am new here and I haven't used openllmetry

@nirga
Copy link
Member Author

nirga commented Apr 11, 2024

@SANJITH-KUMAR-20 sure! If you look across the code you'll see many places where we set an attribute by specifying its name instead of using a constant. We should purge them and move them all to constants here.

@SANJITH-KUMAR-20
Copy link

Oh ok I get it... I will look into it and will start working on this in a few days time!

@ArunimSamudra
Copy link

Hi @nirga, is this issue still open? if not I would like to work on it!

@nirga
Copy link
Member Author

nirga commented May 21, 2024

Yes please!

@ArunimSamudra
Copy link

Thanks

@tibor-reiss tibor-reiss linked a pull request May 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants