Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different KDE implementation #116

Open
tpvasconcelos opened this issue Jun 22, 2023 · 1 comment
Open

Use a different KDE implementation #116

tpvasconcelos opened this issue Jun 22, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tpvasconcelos
Copy link
Owner

tpvasconcelos commented Jun 22, 2023

We have experienced some issues with statsmodels' KDE implementation (see in-line comments in ridgeplot._kde.estimate_density_trace().

Things to keep in mind:

  • Backwards compatibility with the existing ridgeplot() arguments that are passed to statsmodels' KDEUnivariate
  • Performance. e.g., statsmodels provides a faster FFT implementation when using the gaussian kernel.
  • ...more?
@tpvasconcelos tpvasconcelos added enhancement New feature or request good first issue Good for newcomers labels Jun 22, 2023
@fkiraly
Copy link

fkiraly commented Feb 12, 2024

Design-wise, would it not be cleanest to:

  • separate plotting from density estimation a-priori
  • leave some configurability which method to use?

I wanted to write some abstract density estimation intefaces anyway, for skpro (though ofc no need to use them - just saying that I have done some thinking around that topic).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants