Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor logic error in recommendation_system_tutorial/recommendation_system_tutorial_netflix.py #5

Open
oyzh888 opened this issue Feb 17, 2022 · 0 comments

Comments

@oyzh888
Copy link

oyzh888 commented Feb 17, 2022

This line :
top_similar_user_ratings.extend([global_avg_rating[movie]] * (5 - len(ratings)))
should be
top_similar_user_ratings.extend([global_avg_rating[movie]] * (5 - len(top_similar_user_ratings)))

Because len(ratings) is a const large value here which is not right.

https://github.com/towardsai/tutorials/blob/master/recommendation_system_tutorial/recommendation_system_tutorial_netflix.py#L174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant