Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime theme switching and support for theme extensions #129

Open
tomlin7 opened this issue Oct 1, 2023 · 0 comments
Open

Runtime theme switching and support for theme extensions #129

tomlin7 opened this issue Oct 1, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request Extensions API Related to the biscuit extensions API help wanted Extra attention is needed Layout Related to biscuit layout Theming Related to biscuit theming

Comments

@tomlin7
Copy link
Owner

tomlin7 commented Oct 1, 2023

Feature

Currently themes can't be changed at runtime, but will have to restart biscuit for theme change to take effect (infact to change the theme you have to restart anyways since the settings editor is not properly functional yet). The theme manager is in a don't-touch-it-works state, but we can't keep it like that, it does require a makeover.

As of now, I don't see a proper way to handle theme switching theme at runtime, unless we reconfigure every component of the editor from the theme manager (easy to access parts of the editor since the core app class / "base" holds access to every part of the editor including the layout manager)

@tomlin7 tomlin7 added the enhancement New feature or request label Oct 1, 2023
@tomlin7 tomlin7 self-assigned this Oct 1, 2023
@tomlin7 tomlin7 added Extensions API Related to the biscuit extensions API Layout Related to biscuit layout Theming Related to biscuit theming help wanted Extra attention is needed labels Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Extensions API Related to the biscuit extensions API help wanted Extra attention is needed Layout Related to biscuit layout Theming Related to biscuit theming
Projects
None yet
Development

No branches or pull requests

1 participant