Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent error handling #101

Open
tomasvotava opened this issue Nov 27, 2023 · 0 comments
Open

Consistent error handling #101

tomasvotava opened this issue Nov 27, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request open to PRs I agree this should be done but don't have the time to do it myself.

Comments

@tomasvotava
Copy link
Owner

Error handling right now is a mess, each SSO provider class lets exceptions propagate on their own terms. There should be a straightforward and concise set of exceptions raised from the verify_and_process coroutine so that devs can catch the errors and provide end users with relevant information.

Once the structure of exceptions is clear, it should be well documented so that contributors know which exceptions to raise when and devs know which exceptions to expect.

@tomasvotava tomasvotava added documentation Improvements or additions to documentation enhancement New feature or request open to PRs I agree this should be done but don't have the time to do it myself. labels Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request open to PRs I agree this should be done but don't have the time to do it myself.
Projects
None yet
Development

No branches or pull requests

1 participant