New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False-positive unit tests of observables #492
Comments
Hey Tomas :) Let me know what do you think about this :) |
@TarasCZ hi Jirka! Yeah testing of actions is maybe too much ... still having even simple test using Timing of action DOES matter for more complex effects with delays, debounces, race and other complex orchestration which are part of real world applications :) What do you say ? |
Hello, I found that most of your unit tests that tests observable are false-positive, meaning that these tests will pass even when they are supposed to fail.
Minimal reproduction of the bug with instructions:
just change behavior of effect or put one false-positive except (except(false).toBeTruthy()) into the subscribe method and test will still pass
Expected behavior:
Test will fail when they are supposed to
Other information:
example:
this test has its 'except' in subscribe method, which is asynchronous and will be run after the test will complete without error
I would be willing to submit a PR to fix this issue:
Yes, I would like to start working on PR if you agree.
I would also remove these cold and hot helpers because most of the time here we are testing one value emitted from the observable and there are not necessary.
The text was updated successfully, but these errors were encountered: