-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hackbox-demo uses a function that does not exist in hackbox-client v0.0.3 #19
Comments
I can't even see any start button on the host page. Am I missing something? Thank you in advance for your help :) |
I don't think this project is being maintained anymore. Looks like it was more of a prototype at the time. |
Dang. Hoped it could work with what was here. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I setup and ran the hackbox-demo package, but I ran into a bug. On the host screen (i.e., http://localhost:3000/host), when we click the Start Game button, we get the following error message:
TypeError: hackbox.startGame is not a function
onClickStartGame
C:/Git/hackbox/packages/hackbox-demo/src/client/components/Host.js:32
const onClickStartGame = () => { hackbox.startGame({roomId: room.id, gameType}); };
It looks like the hackbos.startGame() function was added to the hackbox-client package during commit 1e85346 (on 1/7/2020). But this change has not yet been pushed to the hackbox-client npm package. So when I run npm install hackbox-client, I am getting a version of this package that does not have this function. Since the hackbox-demo project imports hackbox-client from the node_modules, this new function does not exist for the hackbox-demo project.
Maybe we can fix this issue by updating the npm package to v 0.0.4 that includes the changes from commit 1e85346? :)
The text was updated successfully, but these errors were encountered: