Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernelctl should no longer use /etc/version #885

Open
Eeems opened this issue Jun 5, 2024 · 2 comments
Open

kernelctl should no longer use /etc/version #885

Eeems opened this issue Jun 5, 2024 · 2 comments
Labels
bug Something isn't working packages Add or improve packages of the repository

Comments

@Eeems
Copy link
Member

Eeems commented Jun 5, 2024

Describe the issue
Kernelctl uses /etc/version when creating a backup of the current kernel. As this stops being a unique value in newer OS builds,

To Reproduce
Steps to reproduce the behaviour:

  1. install kernelctl
  2. run kernelctl list to see list of kernels

Expected behaviour
It should be using RELEASE_VERSION from /usr/share/remarkable/update.conf for the OS version number instead.

Upstream issue
N/A

Screenshots
image

System information:

  • toltecctl status output: N/A
  • Package: kernelctl

Additional context
toltecctl has the following code available that kernelctl could call:

get-release-version() {
awk -F= '/RELEASE_VERSION/{print $2}' /usr/share/remarkable/update.conf
}

@Eeems Eeems added bug Something isn't working packages Add or improve packages of the repository labels Jun 5, 2024
@Eeems
Copy link
Member Author

Eeems commented Jun 5, 2024

@Etn40ff would you be willing to make this change?

@Etn40ff
Copy link

Etn40ff commented Jun 7, 2024

@Etn40ff would you be willing to make this change?

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packages Add or improve packages of the repository
Projects
None yet
Development

No branches or pull requests

2 participants