-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows named pipes hits unreachable code during read operation #1660
Milestone
Comments
@carllerche do you have time to look at this? |
Closing because we can't reproduce this. @agneil if you can share code to reproduce this please do, if this an issue we still like to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is an issue we're having trouble reproducing, however, there have been instances of crashing on Windows due to the
unreachable!
line in the snippet of theread_done
function below:mio/src/sys/windows/named_pipe.rs
Lines 859 to 863 in 9bd0e95
I don't see an apparent cause, but I'm curious as to whether it could be possible the snippet below inside
scheduled_read
is returning an error that causesmem::forget
not to be run as anticipated so the state isErr
rather thanPending
?mio/src/sys/windows/named_pipe.rs
Lines 705 to 709 in 9bd0e95
The text was updated successfully, but these errors were encountered: