Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

Properly embed pybookwyrm into binary #62

Open
tmplt opened this issue Dec 16, 2018 · 1 comment
Open

Properly embed pybookwyrm into binary #62

tmplt opened this issue Dec 16, 2018 · 1 comment
Labels
core this issue regards the bookwyrm core enhancement

Comments

@tmplt
Copy link
Owner

tmplt commented Dec 16, 2018

This would allow us to ditch the separate library file, as well as fixing a crash when loading a module that does not import pybookwyrm.
@tmplt tmplt added bug core this issue regards the bookwyrm core labels Dec 16, 2018
tmplt added a commit that referenced this issue Dec 16, 2018
@tmplt
fix(core): import pybookwyrm before running plugins
2663dee 
Fixes test plugins/{missing-find,not-importing-pybookwyrm}.py which
recently broke. Triage.

Related to #62.
@tmplt
Copy link
Owner Author

tmplt commented Dec 22, 2018

Can PYBIND11_EMBEDDED_MODULE help here?

@tmplt tmplt added enhancement and removed bug labels Feb 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
core this issue regards the bookwyrm core enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmplt