Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Hints #473

Open
povilasb opened this issue Aug 10, 2021 · 2 comments
Open

Type Hints #473

povilasb opened this issue Aug 10, 2021 · 2 comments

Comments

@povilasb
Copy link

Hey folks,

I had a successful use of tlslite-ng, but having type hints would definitely improve coding experience given language server is enabled.

  1. would you be willing to accept type hint PRs?
  2. Are you still considering Python 2 support for future releases?
@tomato42
Copy link
Member

I've got no problem with type hints if they are implemented as comments.
Python 2 support is still very much a priority. The primary deployment platform for us is RHEL, so as long as there are supported versions of RHEL that ship with Python 2 as the natively supported version, tlslite-ng will need to support Python 2 (CI running on CentOS 6 is no accident 😄 ).

@povilasb
Copy link
Author

Roger.
Will try to add some type hints as I use the library ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomato42 @povilasb