-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually execute checks defined in base classes #376
Comments
Example (AES, others have similar variety):
Also, 3DES python implementation does not inherit from the base class at all. |
Given the test coverage from tlsfuzzer, it doesn't look like it's something visible/exploitable/inconsistent on TLS level, but it would be nice to fix it to reduce code duplication and unify behaviour between implementations. Mostly so that external users can depend on consistent behaviour of the decryption functions, irrespective of the selected concrete implementation. |
@tomato42 if there is no deadline attached I can take a look at this request. |
@rajdroid there is no deadline, feel free to pick it up |
@tomato42 please assign it to me then. |
Several base classes for crypto algorithms contain sanity checks that never get executed in children classes, which is misleading and could lead to inconsistent error reporting across implementations.
The text was updated successfully, but these errors were encountered: