Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tldr --search "KEYWORDS" does not work #231

Open
fazlearefin opened this issue Feb 22, 2024 · 4 comments · May be fixed by #244
Open

tldr --search "KEYWORDS" does not work #231

fazlearefin opened this issue Feb 22, 2024 · 4 comments · May be fixed by #244
Labels
bug

Comments

@fazlearefin
Copy link
Member

fazlearefin commented Feb 22, 2024 •
edited

tldr --search seems to be not implemented

❯ tldr --version
tldr 3.2.0 (Client Specification 1.5)
❯ tldr --search memory
Please update cache
❯ tldr --search ls
Please update cache
❯
@owenvoke
Copy link
Member

owenvoke commented Feb 22, 2024 •
edited

For some reason it's --update_cache (or -u). 🤔

tldr-python-client/tldr.py

Line 431 in 6536569

parser.add_argument('-u', '--update_cache',

I think we should alias this if possible, so it's --update (but support --update_cache for backwards compatibility).

@fazlearefin
Copy link
Member Author

For some reason it's --update_cache (or -u). 🤔

tldr-python-client/tldr.py

Line 431 in 6536569

parser.add_argument('-u', '--update_cache',

I think we should alias this if possible, so it's --update (but support --update_cache for backwards compatibility).

Sorry for the confusion. I meant to say tldr --search does not work

@kbdharun
Copy link
Member

Can confirm this issue, I was able to replicate it too.

@kbdharun kbdharun added the bug label Feb 22, 2024
@owenvoke
Copy link
Member

Ah, my bad. 👍🏻 Well, I opened a PR to add the --update support anyway. 🤷🏻 #232

@CleanMachine1 CleanMachine1 linked a pull request Apr 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tldr.py: fix search tldr-pages/tldr-python-client
3 participants
@fazlearefin @owenvoke @kbdharun